Unify _to_date converter and add git workflow guidelines#641
Merged
laughingman7743 merged 1 commit intomasterfrom Jan 4, 2026
Merged
Unify _to_date converter and add git workflow guidelines#641laughingman7743 merged 1 commit intomasterfrom
laughingman7743 merged 1 commit intomasterfrom
Conversation
- Extended base _to_date function to handle Union[str, datetime, date] - Removed duplicate _to_date implementations from arrow and polars converters - Added git workflow guidelines to CLAUDE.md (never commit directly to master) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_to_datefunction to handleUnion[str, datetime, date]_to_dateimplementations from arrow and polars convertersChanges
pyathena/converter.py: Extended_to_dateto accept datetime and date objectspyathena/arrow/converter.py: Removed duplicate_to_date, now imports from basepyathena/polars/converter.py: Removed duplicate_to_date, now imports from baseCLAUDE.md: Added Git Workflow section with branch protection guidelinesTest plan
make chkpasses (lint, format, type check)🤖 Generated with Claude Code